From 75d53b40264653df5e6c648d6e7a0cf15a06aa9d Mon Sep 17 00:00:00 2001 From: kaso17 Date: Fri, 22 Feb 2019 17:42:42 +0100 Subject: [PATCH] improve certificate validation error handling --- src/Jackett.Common/Utils/Clients/HttpWebClient.cs | 6 ++++++ src/Jackett.Common/Utils/Clients/HttpWebClient2.cs | 6 ++++++ src/Jackett.Common/Utils/Clients/HttpWebClientNetCore.cs | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/src/Jackett.Common/Utils/Clients/HttpWebClient.cs b/src/Jackett.Common/Utils/Clients/HttpWebClient.cs index e878261d8..60b3a3bea 100644 --- a/src/Jackett.Common/Utils/Clients/HttpWebClient.cs +++ b/src/Jackett.Common/Utils/Clients/HttpWebClient.cs @@ -116,6 +116,12 @@ namespace Jackett.Common.Utils.Clients if (hosts.Contains(request.Host)) return true; } + + if (sslPolicyErrors != SslPolicyErrors.None) + { + throw new Exception("certificate validation failed: " + certificate.ToString()); + } + return sslPolicyErrors == SslPolicyErrors.None; }; } diff --git a/src/Jackett.Common/Utils/Clients/HttpWebClient2.cs b/src/Jackett.Common/Utils/Clients/HttpWebClient2.cs index 6f823622e..f803744ae 100644 --- a/src/Jackett.Common/Utils/Clients/HttpWebClient2.cs +++ b/src/Jackett.Common/Utils/Clients/HttpWebClient2.cs @@ -150,6 +150,12 @@ namespace Jackett.Common.Utils.Clients if (hosts.Contains(request.Host)) return true; } + + if (sslPolicyErrors != SslPolicyErrors.None) + { + throw new Exception("certificate validation failed: " + certificate.ToString()); + } + return sslPolicyErrors == SslPolicyErrors.None; }; } diff --git a/src/Jackett.Common/Utils/Clients/HttpWebClientNetCore.cs b/src/Jackett.Common/Utils/Clients/HttpWebClientNetCore.cs index 49dd44a55..fc66e55d9 100644 --- a/src/Jackett.Common/Utils/Clients/HttpWebClientNetCore.cs +++ b/src/Jackett.Common/Utils/Clients/HttpWebClientNetCore.cs @@ -149,6 +149,12 @@ namespace Jackett.Common.Utils.Clients if (hosts.Contains(request.RequestUri.Host)) return true; } + + if (sslPolicyErrors != SslPolicyErrors.None) + { + throw new Exception("certificate validation failed: " + certificate.ToString()); + } + return sslPolicyErrors == SslPolicyErrors.None; };