shpaq/Jackett-Jackett
1
0
Fork 0
mirror of https://github.com/Jackett/Jackett.git synced 2025-09-17 17:34:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

core: Fix IsEmptyOrNull to return true when IsNull (#7338) resolves #7333

Browse Source
This commit is contained in:
Cory
2020-02-26 12:24:36 -06:00
committed by GitHub
parent 427b556869
commit b9b10e4e91
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Jackett.Common/Utils/Extensions.cs
View File

@@ -64,8 +64,11 @@ namespace Jackett.Common.Utils
// IEnumerable class above already does this. All ICollection are IEnumerable, so favor IEnumerable? // IEnumerable class above already does this. All ICollection are IEnumerable, so favor IEnumerable?
public static bool IsEmpty<T>(this ICollection<T> obj) => obj.Count == 0; public static bool IsEmpty<T>(this ICollection<T> obj) => obj.Count == 0;
// obj == null || obj.IsEmpty() causes VS to suggest merging sequential checks
public static bool IsEmptyOrNull<T>(this ICollection<T> obj) => obj?.IsEmpty() == true; // the result is obj?.IsEmpty() == true which returns false when null
// Other options are obj?.IsEmpty() == true || obj == null Or (obj?.IsEmpty()).GetValueOrDefault(true)
// All three options remove the suggestion and give the intended result of this function
public static bool IsEmptyOrNull<T>(this ICollection<T> obj) => obj?.IsEmpty() ?? true;
} }
public static class XElementExtension public static class XElementExtension