From c32463523c53ff52eab21945f2d2a4ad291758fb Mon Sep 17 00:00:00 2001
From: Diego Heras <ngosang@hotmail.es>
Date: Sun, 10 May 2020 22:32:24 +0200
Subject: [PATCH] horriblesubs: fix torrents without download link (#8589)

---
 src/Jackett.Common/Indexers/HorribleSubs.cs | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/Jackett.Common/Indexers/HorribleSubs.cs b/src/Jackett.Common/Indexers/HorribleSubs.cs
index a6558cb34..3c4fbbb55 100644
--- a/src/Jackett.Common/Indexers/HorribleSubs.cs
+++ b/src/Jackett.Common/Indexers/HorribleSubs.cs
@@ -201,15 +201,15 @@ namespace Jackett.Common.Indexers
 
                     var p480 = row.QuerySelector(".link-480p");
                     if (p480 != null) // size = 400 MB
-                        releases.Add(MakeRelease(p480, $"{title} [480p]", 419430400, comments, publishDate));
+                        AddRelease(releases, p480, $"{title} [480p]", 419430400, comments, publishDate);
 
                     var p720 = row.QuerySelector(".link-720p");
                     if (p720 != null) // size 700 MB
-                        releases.Add(MakeRelease(p720, $"{title} [720p]", 734003200, comments, publishDate));
+                        AddRelease(releases, p720, $"{title} [720p]", 734003200, comments, publishDate);
 
                     var p1080 = row.QuerySelector(".link-1080p");
                     if (p1080 != null) // size 1.4 GB
-                        releases.Add(MakeRelease(p1080, $"{title} [1080p]", 1503238553, comments, publishDate));
+                        AddRelease(releases, p1080, $"{title} [1080p]", 1503238553, comments, publishDate);
                 }
             }
             catch (Exception ex)
@@ -219,8 +219,8 @@ namespace Jackett.Common.Indexers
             return releases;
         }
 
-        private static ReleaseInfo MakeRelease(IElement releaseSelector, string title, long size, Uri comments,
-                                               DateTime publishDate)
+        private static void AddRelease(List<ReleaseInfo> releases, IElement releaseSelector, string title, long size,
+                                       Uri comments, DateTime publishDate)
         {
             Uri link = null;
             Uri magnet = null;
@@ -236,6 +236,10 @@ namespace Jackett.Common.Indexers
                 guid = link;
             }
 
+            // eg https://horriblesubs.info/shows/space-brothers/#38
+            if (magnet == null && link == null)
+                return;
+
             var release = new ReleaseInfo
             {
                 Title = title,
@@ -254,7 +258,8 @@ namespace Jackett.Common.Indexers
                 DownloadVolumeFactor = 0,
                 UploadVolumeFactor = 1
             };
-            return release;
+
+            releases.Add(release);
         }
     }
 }