From 3283d144f5a3095c6c3684bef618ce47ee59ae17 Mon Sep 17 00:00:00 2001 From: Bogdan Date: Thu, 14 Sep 2023 18:22:53 +0300 Subject: [PATCH] Ignore invalid cookies when adding response cookies to CookieContainer Fixes #1868 --- src/NzbDrone.Common/Http/HttpClient.cs | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/src/NzbDrone.Common/Http/HttpClient.cs b/src/NzbDrone.Common/Http/HttpClient.cs index a1e6f0243..470f4f5c4 100644 --- a/src/NzbDrone.Common/Http/HttpClient.cs +++ b/src/NzbDrone.Common/Http/HttpClient.cs @@ -221,11 +221,18 @@ namespace NzbDrone.Common.Http }; } - sourceContainer.Add((Uri)request.Url, cookie); - - if (request.StoreRequestCookie) + try { - presistentContainer.Add((Uri)request.Url, cookie); + sourceContainer.Add((Uri)request.Url, cookie); + + if (request.StoreRequestCookie) + { + presistentContainer.Add((Uri)request.Url, cookie); + } + } + catch (CookieException ex) + { + _logger.Debug(ex, "Invalid cookie in {0}", (Uri)request.Url); } } } @@ -260,7 +267,14 @@ namespace NzbDrone.Common.Http }; } - sourceContainer.Add((Uri)request.Url, cookie); + try + { + sourceContainer.Add((Uri)request.Url, cookie); + } + catch (CookieException ex) + { + _logger.Debug(ex, "Invalid cookie in {0}", (Uri)request.Url); + } } }