mirror of
https://github.com/Prowlarr/Prowlarr.git
synced 2025-10-03 09:09:42 +02:00
Remove unnecessary assignments to default type value
The .NET runtime initializes all fields of reference types to their default values before running the constructor. In most cases, explicitly initializing a field to its default value in a constructor is redundant, adding maintenance costs and potentially degrading performance
This commit is contained in:
@@ -179,7 +179,6 @@ dotnet_diagnostic.CA1720.severity = suggestion
|
|||||||
dotnet_diagnostic.CA1721.severity = suggestion
|
dotnet_diagnostic.CA1721.severity = suggestion
|
||||||
dotnet_diagnostic.CA1724.severity = suggestion
|
dotnet_diagnostic.CA1724.severity = suggestion
|
||||||
dotnet_diagnostic.CA1725.severity = suggestion
|
dotnet_diagnostic.CA1725.severity = suggestion
|
||||||
dotnet_diagnostic.CA1805.severity = suggestion
|
|
||||||
dotnet_diagnostic.CA1806.severity = suggestion
|
dotnet_diagnostic.CA1806.severity = suggestion
|
||||||
dotnet_diagnostic.CA1810.severity = suggestion
|
dotnet_diagnostic.CA1810.severity = suggestion
|
||||||
dotnet_diagnostic.CA1812.severity = suggestion
|
dotnet_diagnostic.CA1812.severity = suggestion
|
||||||
|
@@ -1,4 +1,4 @@
|
|||||||
using System;
|
using System;
|
||||||
using System.Collections.Generic;
|
using System.Collections.Generic;
|
||||||
using System.Linq;
|
using System.Linq;
|
||||||
using System.Threading;
|
using System.Threading;
|
||||||
@@ -19,7 +19,7 @@ namespace NzbDrone.Common.TPL
|
|||||||
private readonly int _maxDegreeOfParallelism;
|
private readonly int _maxDegreeOfParallelism;
|
||||||
|
|
||||||
/// <summary>Whether the scheduler is currently processing work items.</summary>
|
/// <summary>Whether the scheduler is currently processing work items.</summary>
|
||||||
private int _delegatesQueuedOrRunning = 0;
|
private int _delegatesQueuedOrRunning;
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Initializes an instance of the LimitedConcurrencyLevelTaskScheduler class with the
|
/// Initializes an instance of the LimitedConcurrencyLevelTaskScheduler class with the
|
||||||
|
@@ -15,9 +15,9 @@ namespace NzbDrone.Core.Datastore
|
|||||||
|
|
||||||
private const DbType EnumerableMultiParameter = (DbType)(-1);
|
private const DbType EnumerableMultiParameter = (DbType)(-1);
|
||||||
private readonly string _paramNamePrefix;
|
private readonly string _paramNamePrefix;
|
||||||
private readonly bool _requireConcreteValue = false;
|
private readonly bool _requireConcreteValue;
|
||||||
private int _paramCount = 0;
|
private int _paramCount;
|
||||||
private bool _gotConcreteValue = false;
|
private bool _gotConcreteValue;
|
||||||
|
|
||||||
public WhereBuilderPostgres(Expression filter, bool requireConcreteValue, int seq)
|
public WhereBuilderPostgres(Expression filter, bool requireConcreteValue, int seq)
|
||||||
{
|
{
|
||||||
|
@@ -15,9 +15,9 @@ namespace NzbDrone.Core.Datastore
|
|||||||
|
|
||||||
private const DbType EnumerableMultiParameter = (DbType)(-1);
|
private const DbType EnumerableMultiParameter = (DbType)(-1);
|
||||||
private readonly string _paramNamePrefix;
|
private readonly string _paramNamePrefix;
|
||||||
private readonly bool _requireConcreteValue = false;
|
private readonly bool _requireConcreteValue;
|
||||||
private int _paramCount = 0;
|
private int _paramCount;
|
||||||
private bool _gotConcreteValue = false;
|
private bool _gotConcreteValue;
|
||||||
|
|
||||||
public WhereBuilderSqlite(Expression filter, bool requireConcreteValue, int seq)
|
public WhereBuilderSqlite(Expression filter, bool requireConcreteValue, int seq)
|
||||||
{
|
{
|
||||||
|
@@ -34,8 +34,8 @@ namespace NzbDrone.Core.HealthCheck
|
|||||||
|
|
||||||
private readonly ICached<HealthCheck> _healthCheckResults;
|
private readonly ICached<HealthCheck> _healthCheckResults;
|
||||||
|
|
||||||
private bool _hasRunHealthChecksAfterGracePeriod = false;
|
private bool _hasRunHealthChecksAfterGracePeriod;
|
||||||
private bool _isRunningHealthChecksAfterGracePeriod = false;
|
private bool _isRunningHealthChecksAfterGracePeriod;
|
||||||
|
|
||||||
public HealthCheckService(IEnumerable<IProvideHealthCheck> healthChecks,
|
public HealthCheckService(IEnumerable<IProvideHealthCheck> healthChecks,
|
||||||
IServerSideNotificationService serverSideNotificationService,
|
IServerSideNotificationService serverSideNotificationService,
|
||||||
|
@@ -44,7 +44,7 @@ namespace NzbDrone.Core.Indexers.Cardigann
|
|||||||
public double? RequestDelay { get; set; }
|
public double? RequestDelay { get; set; }
|
||||||
public List<string> Links { get; set; }
|
public List<string> Links { get; set; }
|
||||||
public List<string> Legacylinks { get; set; }
|
public List<string> Legacylinks { get; set; }
|
||||||
public bool Followredirect { get; set; } = false;
|
public bool Followredirect { get; set; }
|
||||||
public bool TestLinkTorrent { get; set; } = true;
|
public bool TestLinkTorrent { get; set; } = true;
|
||||||
public List<string> Certificates { get; set; }
|
public List<string> Certificates { get; set; }
|
||||||
public CapabilitiesBlock Caps { get; set; }
|
public CapabilitiesBlock Caps { get; set; }
|
||||||
@@ -95,7 +95,7 @@ namespace NzbDrone.Core.Indexers.Cardigann
|
|||||||
public List<string> Cookies { get; set; }
|
public List<string> Cookies { get; set; }
|
||||||
public string Method { get; set; }
|
public string Method { get; set; }
|
||||||
public string Form { get; set; }
|
public string Form { get; set; }
|
||||||
public bool Selectors { get; set; } = false;
|
public bool Selectors { get; set; }
|
||||||
public Dictionary<string, string> Inputs { get; set; }
|
public Dictionary<string, string> Inputs { get; set; }
|
||||||
public Dictionary<string, SelectorBlock> Selectorinputs { get; set; }
|
public Dictionary<string, SelectorBlock> Selectorinputs { get; set; }
|
||||||
public Dictionary<string, SelectorBlock> Getselectorinputs { get; set; }
|
public Dictionary<string, SelectorBlock> Getselectorinputs { get; set; }
|
||||||
@@ -114,7 +114,7 @@ namespace NzbDrone.Core.Indexers.Cardigann
|
|||||||
public class SelectorBlock
|
public class SelectorBlock
|
||||||
{
|
{
|
||||||
public string Selector { get; set; }
|
public string Selector { get; set; }
|
||||||
public bool Optional { get; set; } = false;
|
public bool Optional { get; set; }
|
||||||
public string Text { get; set; }
|
public string Text { get; set; }
|
||||||
public string Attribute { get; set; }
|
public string Attribute { get; set; }
|
||||||
public string Remove { get; set; }
|
public string Remove { get; set; }
|
||||||
@@ -157,7 +157,7 @@ namespace NzbDrone.Core.Indexers.Cardigann
|
|||||||
public int After { get; set; }
|
public int After { get; set; }
|
||||||
public SelectorBlock Dateheaders { get; set; }
|
public SelectorBlock Dateheaders { get; set; }
|
||||||
public SelectorBlock Count { get; set; }
|
public SelectorBlock Count { get; set; }
|
||||||
public bool Multiple { get; set; } = false;
|
public bool Multiple { get; set; }
|
||||||
}
|
}
|
||||||
|
|
||||||
public class SearchPathBlock : RequestBlock
|
public class SearchPathBlock : RequestBlock
|
||||||
|
@@ -27,7 +27,7 @@ namespace NzbDrone.Mono.Disk
|
|||||||
|
|
||||||
private static Dictionary<string, bool> _fileSystems;
|
private static Dictionary<string, bool> _fileSystems;
|
||||||
|
|
||||||
private bool _hasLoggedProcMountFailure = false;
|
private bool _hasLoggedProcMountFailure;
|
||||||
|
|
||||||
public ProcMountProvider(Logger logger)
|
public ProcMountProvider(Logger logger)
|
||||||
{
|
{
|
||||||
|
Reference in New Issue
Block a user