From 32e9d4b9dde17c71007bca1a12b81e7ef9cf80ac Mon Sep 17 00:00:00 2001
From: auricom <27022259+auricom@users.noreply.github.com>
Date: Thu, 6 Feb 2025 21:40:56 +0100
Subject: [PATCH] fixup! feat: opnsense backup

---
 kubernetes/apps/default/homelab/opnsense/backup/backup.sh | 8 +++++++-
 .../apps/default/homelab/opnsense/backup/helmrelease.yaml | 4 ++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/kubernetes/apps/default/homelab/opnsense/backup/backup.sh b/kubernetes/apps/default/homelab/opnsense/backup/backup.sh
index 42164a27a..b6c05911c 100644
--- a/kubernetes/apps/default/homelab/opnsense/backup/backup.sh
+++ b/kubernetes/apps/default/homelab/opnsense/backup/backup.sh
@@ -1,7 +1,13 @@
 #!/usr/bin/env bash
 
-set -o nounset
+# Exit on error, undefined vars, pipe failures, and debug each command
 set -o errexit
+set -o nounset
+set -o pipefail
+set -o xtrace
+
+# Cleanup temporary files on script exit
+trap 'rm -f "/tmp/${config_filename}"' EXIT
 
 config_filename="$(date "+%Y%m%d-%H%M%S").xml"
 
diff --git a/kubernetes/apps/default/homelab/opnsense/backup/helmrelease.yaml b/kubernetes/apps/default/homelab/opnsense/backup/helmrelease.yaml
index 910005d51..148c34e57 100644
--- a/kubernetes/apps/default/homelab/opnsense/backup/helmrelease.yaml
+++ b/kubernetes/apps/default/homelab/opnsense/backup/helmrelease.yaml
@@ -37,13 +37,13 @@ spec:
           app:
             image:
               repository: ghcr.io/auricom/kubectl
-              tag: 1.32.1@sha256:b01d7c1b5d9e900119a7568fc4d08a3a46afb65d430ed66173cdf101b4f211db
+              tag: 1.32.1@sha256:33ff33f4d00dc6779198b0da0200caddad8c191c59fe427dcaebe89695298ff0
             command:
               - /bin/bash
               - /app/backup.sh
             env:
               OPNSENSE_URL: "https://opnsense.${SECRET_INTERNAL_DOMAIN}"
-              S3_URL: "https://minio.${SECRET_INTERNAL_DOMAIN}"
+              S3_URL: "https://s3.${SECRET_INTERNAL_DOMAIN}"
             envFrom:
               - secretRef:
                   name: homelab-opnsense-backup-secret