From 0116c13e0632d1ccec43299fbb10cd71db45bc29 Mon Sep 17 00:00:00 2001
From: Gauthier <mail@gauthierth.fr>
Date: Wed, 24 Jul 2024 21:31:18 +0200
Subject: [PATCH] fix(api): fix nextjs error handler (#882)

This PR removes a custom error handler that sometimes caused issues by sending headers after some
content had already been sent.
---
 server/index.ts | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/server/index.ts b/server/index.ts
index 2d90f05c3..00ddf1210 100644
--- a/server/index.ts
+++ b/server/index.ts
@@ -26,7 +26,6 @@ import { getClientIp } from '@supercharge/request-ip';
 import { TypeormStore } from 'connect-typeorm/out';
 import cookieParser from 'cookie-parser';
 import csurf from 'csurf';
-import type { NextFunction, Request, Response } from 'express';
 import express from 'express';
 import * as OpenApiValidator from 'express-openapi-validator';
 import type { Store } from 'express-session';
@@ -180,6 +179,16 @@ app
     );
     const apiDocs = YAML.load(API_SPEC_PATH);
     server.use('/api-docs', swaggerUi.serve, swaggerUi.setup(apiDocs));
+    /**
+     * Workaround to avoid the error from the OpenAPI validator when an user send a
+     * request without any session cookie
+     */
+    server.use((req, res, next) => {
+      if (!req.cookies['connect.sid']) {
+        req.cookies['connect.sid'] = 'none';
+      }
+      next();
+    });
     server.use(
       OpenApiValidator.middleware({
         apiSpec: API_SPEC_PATH,
@@ -203,23 +212,7 @@ app
     // Do not set cookies so CDNs can cache them
     server.use('/imageproxy', clearCookies, imageproxy);
 
-    server.get('*', (req, res) => handle(req, res));
-    server.use(
-      (
-        err: { status: number; message: string; errors: string[] },
-        _req: Request,
-        res: Response,
-        // We must provide a next function for the function signature here even though its not used
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        _next: NextFunction
-      ) => {
-        // format error
-        res.status(err.status || 500).json({
-          message: err.message,
-          errors: err.errors,
-        });
-      }
-    );
+    server.all('*', (req, res) => handle(req, res));
 
     const port = Number(process.env.PORT) || 5055;
     const host = process.env.HOST;