From 07dc8d755a0e94d100ecd8b1e950e43da1c0a7dd Mon Sep 17 00:00:00 2001 From: Gauthier Date: Fri, 9 May 2025 18:42:32 +0200 Subject: [PATCH] fix(mediasubscriber): remove async from afterInsert and afterUpdate (#4136) Asynchronous operations introduced in commit 3b9e195496c3db1f794549786b123a3ff55b08a0 caused issues during media requests: the mediaId was not properly assigned and remained null. --- server/subscriber/MediaRequestSubscriber.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/subscriber/MediaRequestSubscriber.ts b/server/subscriber/MediaRequestSubscriber.ts index 9ac6e9b44..e67158dbf 100644 --- a/server/subscriber/MediaRequestSubscriber.ts +++ b/server/subscriber/MediaRequestSubscriber.ts @@ -753,35 +753,35 @@ export class MediaRequestSubscriber await manager.save(fullMedia); } - public async afterUpdate(event: UpdateEvent): Promise { + public afterUpdate(event: UpdateEvent): void { if (!event.entity) { return; } - await this.sendToRadarr(event.entity as MediaRequest); - await this.sendToSonarr(event.entity as MediaRequest); + this.sendToRadarr(event.entity as MediaRequest); + this.sendToSonarr(event.entity as MediaRequest); - await this.updateParentStatus(event.entity as MediaRequest); + this.updateParentStatus(event.entity as MediaRequest); if (event.entity.status === MediaRequestStatus.COMPLETED) { if (event.entity.media.mediaType === MediaType.MOVIE) { - await this.notifyAvailableMovie(event.entity as MediaRequest); + this.notifyAvailableMovie(event.entity as MediaRequest); } if (event.entity.media.mediaType === MediaType.TV) { - await this.notifyAvailableSeries(event.entity as MediaRequest); + this.notifyAvailableSeries(event.entity as MediaRequest); } } } - public async afterInsert(event: InsertEvent): Promise { + public afterInsert(event: InsertEvent): void { if (!event.entity) { return; } - await this.sendToRadarr(event.entity as MediaRequest); - await this.sendToSonarr(event.entity as MediaRequest); + this.sendToRadarr(event.entity as MediaRequest); + this.sendToSonarr(event.entity as MediaRequest); - await this.updateParentStatus(event.entity as MediaRequest); + this.updateParentStatus(event.entity as MediaRequest); } public async afterRemove(event: RemoveEvent): Promise {