From 421f4c17f0f206bbe7bfcbf2819014b8c7f55b6a Mon Sep 17 00:00:00 2001
From: sct <sctsnipe@gmail.com>
Date: Thu, 21 Jan 2021 09:37:47 +0000
Subject: [PATCH] fix(api): prevent duplicate movie requests

fixes #705
---
 server/routes/request.ts | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/server/routes/request.ts b/server/routes/request.ts
index 0b7267245..4750be2da 100644
--- a/server/routes/request.ts
+++ b/server/routes/request.ts
@@ -114,20 +114,40 @@ requestRoutes.post(
           status4k: req.body.is4k ? MediaStatus.PENDING : MediaStatus.UNKNOWN,
           mediaType: req.body.mediaType,
         });
-        await mediaRepository.save(media);
       } else {
         if (media.status === MediaStatus.UNKNOWN && !req.body.is4k) {
           media.status = MediaStatus.PENDING;
-          await mediaRepository.save(media);
         }
 
         if (media.status4k === MediaStatus.UNKNOWN && req.body.is4k) {
           media.status4k = MediaStatus.PENDING;
-          await mediaRepository.save(media);
         }
       }
 
       if (req.body.mediaType === 'movie') {
+        const existing = await requestRepository.findOne({
+          where: {
+            media: {
+              tmdbId: tmdbMedia.id,
+            },
+            requestedBy: req.user,
+            is4k: req.body.is4k,
+          },
+        });
+
+        if (existing) {
+          logger.warn('Duplicate request for media blocked', {
+            tmdbId: tmdbMedia.id,
+            mediaType: req.body.mediaType,
+          });
+          return next({
+            status: 409,
+            message: 'Request for this media already exists.',
+          });
+        }
+
+        await mediaRepository.save(media);
+
         const request = new MediaRequest({
           type: MediaType.MOVIE,
           media,
@@ -185,6 +205,8 @@ requestRoutes.post(
           });
         }
 
+        await mediaRepository.save(media);
+
         const request = new MediaRequest({
           type: MediaType.TV,
           media: {