shpaq/sct-overseerr
1
0
Fork 0
mirror of https://github.com/sct/overseerr.git synced 2025-09-17 17:24:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(auth): handle sign-in attempts from emails with no password (#933)

Browse Source 
* fix(auth): dont reject promise when missing password

* fix(auth): use static fallback error message
This commit is contained in:
Jakob Ankarhem
2021-02-15 09:34:40 +01:00
committed by GitHub
parent 8a7fa00164
commit 5e37a96bc0
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/entity/User.ts
View File

@@ -108,11 +108,11 @@ export class User {
} }
public passwordMatch(password: string): Promise<boolean> { public passwordMatch(password: string): Promise<boolean> {
return new Promise((resolve, reject) => { return new Promise((resolve) => {
if (this.password) { if (this.password) {
resolve(bcrypt.compare(password, this.password)); resolve(bcrypt.compare(password, this.password));
} else { } else {
return reject(false); return resolve(false);
} }
}); });
} }

5
server/routes/auth.ts
View File

@@ -176,7 +176,10 @@ authRoutes.post('/local', async (req, res, next) => {
return res.status(200).json(user?.filter() ?? {}); return res.status(200).json(user?.filter() ?? {});
} catch (e) { } catch (e) {
logger.error(e.message, { label: 'Auth' }); logger.error('Something went wrong when trying to authenticate', {
label: 'Auth',
error: e.message,
});
return next({ return next({
status: 500, status: 500,
message: 'Something went wrong.', message: 'Something went wrong.',