feat(notifications): control notifcation types per agent

closes #513

server/lib/notifications/agents/discord.ts

@@ -1,5 +1,5 @@
 import axios from 'axios';
-import { Notification } from '..';
+import { hasNotificationType, Notification } from '..';
 import logger from '../../../logger';
 import { getSettings, NotificationAgentDiscord } from '../../settings';
 import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
@@ -196,10 +196,12 @@ class DiscordAgent
     };
   }
 
-  // TODO: Add checking for type here once we add notification type filters for agents
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public shouldSend(_type: Notification): boolean {
-    if (this.getSettings().enabled && this.getSettings().options.webhookUrl) {
+  public shouldSend(type: Notification): boolean {
+    if (
+      this.getSettings().enabled &&
+      this.getSettings().options.webhookUrl &&
+      hasNotificationType(type, this.getSettings().types)
+    ) {
       return true;
     }
 

server/lib/notifications/agents/email.ts

@@ -1,5 +1,5 @@
 import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
-import { Notification } from '..';
+import { hasNotificationType, Notification } from '..';
 import path from 'path';
 import { getSettings, NotificationAgentEmail } from '../../settings';
 import nodemailer from 'nodemailer';
@@ -22,12 +22,13 @@ class EmailAgent
     return settings.notifications.agents.email;
   }
 
-  // TODO: Add checking for type here once we add notification type filters for agents
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public shouldSend(_type: Notification): boolean {
+  public shouldSend(type: Notification): boolean {
     const settings = this.getSettings();
 
-    if (settings.enabled) {
+    if (
+      settings.enabled &&
+      hasNotificationType(type, this.getSettings().types)
+    ) {
       return true;
     }
 

server/lib/notifications/agents/slack.ts

@@ -1,5 +1,5 @@
 import axios from 'axios';
-import { Notification } from '..';
+import { hasNotificationType, Notification } from '..';
 import logger from '../../../logger';
 import { getSettings, NotificationAgentSlack } from '../../settings';
 import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
@@ -187,10 +187,12 @@ class SlackAgent
     };
   }
 
-  // TODO: Add checking for type here once we add notification type filters for agents
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public shouldSend(_type: Notification): boolean {
-    if (this.getSettings().enabled && this.getSettings().options.webhookUrl) {
+  public shouldSend(type: Notification): boolean {
+    if (
+      this.getSettings().enabled &&
+      this.getSettings().options.webhookUrl &&
+      hasNotificationType(type, this.getSettings().types)
+    ) {
       return true;
     }
 

server/lib/notifications/agents/telegram.ts

@@ -1,5 +1,5 @@
 import axios from 'axios';
-import { Notification } from '..';
+import { hasNotificationType, Notification } from '..';
 import logger from '../../../logger';
 import { getSettings, NotificationAgentTelegram } from '../../settings';
 import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
@@ -25,13 +25,12 @@ class TelegramAgent
     return settings.notifications.agents.telegram;
   }
 
-  // TODO: Add checking for type here once we add notification type filters for agents
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public shouldSend(_type: Notification): boolean {
+  public shouldSend(type: Notification): boolean {
     if (
       this.getSettings().enabled &&
       this.getSettings().options.botAPI &&
-      this.getSettings().options.chatId
+      this.getSettings().options.chatId &&
+      hasNotificationType(type, this.getSettings().types)
     ) {
       return true;
     }

server/lib/notifications/index.ts

@@ -9,6 +9,27 @@ export enum Notification {
   TEST_NOTIFICATION = 32,
 }
 
+export const hasNotificationType = (
+  types: Notification | Notification[],
+  value: number
+): boolean => {
+  let total = 0;
+
+  // If we are not checking any notifications, bail out and return true
+  if (types === 0) {
+    return true;
+  }
+
+  if (Array.isArray(types)) {
+    // Combine all notification values into one
+    total = types.reduce((a, v) => a + v, 0);
+  } else {
+    total = types;
+  }
+
+  return !!(value & total);
+};
+
 class NotificationManager {
   private activeAgents: NotificationAgent[] = [];