fix: address unhandled promise rejections & bump node to v16.13 (#2398)

* fix: unhandled promise rejections

* build(deps): bump node from 14.18 to 16.13

* fix: unhandled promise rejection in new Plex users endpoint

* fix: build error

Co-authored-by: Ryan Cohen <ryan@sct.dev>

server/subscriber/IssueSubscriber.ts

@@ -11,6 +11,7 @@ import { MediaType } from '../constants/media';
 import Issue from '../entity/Issue';
 import notificationManager, { Notification } from '../lib/notifications';
 import { Permission } from '../lib/permissions';
+import logger from '../logger';
 
 @EventSubscriber()
 export class IssueSubscriber implements EntitySubscriberInterface<Issue> {
@@ -22,72 +23,81 @@ export class IssueSubscriber implements EntitySubscriberInterface<Issue> {
     let title: string;
     let image: string;
     const tmdb = new TheMovieDb();
-    if (entity.media.mediaType === MediaType.MOVIE) {
-      const movie = await tmdb.getMovie({ movieId: entity.media.tmdbId });
 
-      title = `${movie.title}${
-        movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
-    } else {
-      const tvshow = await tmdb.getTvShow({ tvId: entity.media.tmdbId });
+    try {
+      if (entity.media.mediaType === MediaType.MOVIE) {
+        const movie = await tmdb.getMovie({ movieId: entity.media.tmdbId });
 
-      title = `${tvshow.name}${
-        tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
-    }
+        title = `${movie.title}${
+          movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
+      } else {
+        const tvshow = await tmdb.getTvShow({ tvId: entity.media.tmdbId });
 
-    const [firstComment] = sortBy(entity.comments, 'id');
-    const extra: { name: string; value: string }[] = [];
-
-    if (entity.media.mediaType === MediaType.TV && entity.problemSeason > 0) {
-      extra.push({
-        name: 'Affected Season',
-        value: entity.problemSeason.toString(),
-      });
-
-      if (entity.problemEpisode > 0) {
-        extra.push({
-          name: 'Affected Episode',
-          value: entity.problemEpisode.toString(),
-        });
+        title = `${tvshow.name}${
+          tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
       }
-    }
 
-    notificationManager.sendNotification(type, {
-      event:
-        type === Notification.ISSUE_CREATED
-          ? `New ${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Reported`
-          : type === Notification.ISSUE_RESOLVED
-          ? `${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Resolved`
-          : `${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Reopened`,
-      subject: title,
-      message: firstComment.message,
-      issue: entity,
-      media: entity.media,
-      image,
-      extra,
-      notifyAdmin: true,
-      notifyUser:
-        !entity.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
-        (type === Notification.ISSUE_RESOLVED ||
-          type === Notification.ISSUE_REOPENED)
-          ? entity.createdBy
-          : undefined,
-    });
+      const [firstComment] = sortBy(entity.comments, 'id');
+      const extra: { name: string; value: string }[] = [];
+
+      if (entity.media.mediaType === MediaType.TV && entity.problemSeason > 0) {
+        extra.push({
+          name: 'Affected Season',
+          value: entity.problemSeason.toString(),
+        });
+
+        if (entity.problemEpisode > 0) {
+          extra.push({
+            name: 'Affected Episode',
+            value: entity.problemEpisode.toString(),
+          });
+        }
+      }
+
+      notificationManager.sendNotification(type, {
+        event:
+          type === Notification.ISSUE_CREATED
+            ? `New ${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Reported`
+            : type === Notification.ISSUE_RESOLVED
+            ? `${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Resolved`
+            : `${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Reopened`,
+        subject: title,
+        message: firstComment.message,
+        issue: entity,
+        media: entity.media,
+        image,
+        extra,
+        notifyAdmin: true,
+        notifyUser:
+          !entity.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
+          (type === Notification.ISSUE_RESOLVED ||
+            type === Notification.ISSUE_REOPENED)
+            ? entity.createdBy
+            : undefined,
+      });
+    } catch (e) {
+      logger.error('Something went wrong sending issue notification(s)', {
+        label: 'Notifications',
+        errorMessage: e.message,
+        issueId: entity.id,
+      });
+    }
   }
 
   public afterInsert(event: InsertEvent<Issue>): void {