shpaq/sct-overseerr
1
0
Fork 0
mirror of https://github.com/sct/overseerr.git synced 2025-09-17 17:24:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(auth): resolve local/password authentication issues (#2677)

Browse Source 
* fix(auth): only add Plex ID to user after verifying server access

* fix(auth): do not fail local auth if fetching Plex users is unsuccessful
This commit is contained in:
TheCatLady
2022-04-05 19:31:14 -04:00
committed by GitHub
parent 341e3b8f06
commit b75fc7b238
1 changed files with 34 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
server/routes/auth.ts
View File

@@ -210,6 +210,7 @@ authRoutes.post('/local', async (req, res, next) => {
const mainPlexTv = new PlexTvAPI(mainUser.plexToken ?? ''); const mainPlexTv = new PlexTvAPI(mainUser.plexToken ?? '');
if (!user.plexId) { if (!user.plexId) {
try {
const plexUsersResponse = await mainPlexTv.getUsers(); const plexUsersResponse = await mainPlexTv.getUsers();
const account = plexUsersResponse.MediaContainer.User.find( const account = plexUsersResponse.MediaContainer.User.find(
(account) => (account) =>
@@ -217,15 +218,21 @@ authRoutes.post('/local', async (req, res, next) => {
account.$.email.toLowerCase() === user.email.toLowerCase() account.$.email.toLowerCase() === user.email.toLowerCase()
)?.$; )?.$;
if (account) { if (
logger.info('Found matching Plex user; updating user with Plex data', { account &&
(await mainPlexTv.checkUserAccess(parseInt(account.id)))
) {
logger.info(
'Found matching Plex user; updating user with Plex data',
{
label: 'API', label: 'API',
ip: req.ip, ip: req.ip,
email: body.email, email: body.email,
userId: user.id, userId: user.id,
plexId: account.id, plexId: account.id,
plexUsername: account.username, plexUsername: account.username,
}); }
);
user.plexId = parseInt(account.id); user.plexId = parseInt(account.id);
user.avatar = account.thumb; user.avatar = account.thumb;
@@ -235,6 +242,12 @@ authRoutes.post('/local', async (req, res, next) => {
await userRepository.save(user); await userRepository.save(user);
} }
} catch (e) {
logger.error('Something went wrong fetching Plex users', {
label: 'API',
errorMessage: e.message,
});
}
} }
if ( if (