refactor: update a few dev deps and convert to using type imports where possible (#2886)

* build: bump deps and add some new eslint rules

* refactor: run eslint --fix on code to convert to type imports where possible

server/routes/discover.ts

@@ -3,8 +3,8 @@ import { sortBy } from 'lodash';
 import TheMovieDb from '../api/themoviedb';
 import { MediaType } from '../constants/media';
 import Media from '../entity/Media';
-import { User } from '../entity/User';
-import { GenreSliderItem } from '../interfaces/api/discoverInterfaces';
+import type { User } from '../entity/User';
+import type { GenreSliderItem } from '../interfaces/api/discoverInterfaces';
 import { getSettings } from '../lib/settings';
 import logger from '../logger';
 import { mapProductionCompany } from '../models/Movie';

server/routes/index.ts

@@ -1,8 +1,11 @@
 import { Router } from 'express';
 import GithubAPI from '../api/github';
 import TheMovieDb from '../api/themoviedb';
-import { TmdbMovieResult, TmdbTvResult } from '../api/themoviedb/interfaces';
-import { StatusResponse } from '../interfaces/api/settingsInterfaces';
+import type {
+  TmdbMovieResult,
+  TmdbTvResult,
+} from '../api/themoviedb/interfaces';
+import type { StatusResponse } from '../interfaces/api/settingsInterfaces';
 import { Permission } from '../lib/permissions';
 import { getSettings } from '../lib/settings';
 import logger from '../logger';

server/routes/issue.ts

@@ -4,7 +4,7 @@ import { IssueStatus, IssueType } from '../constants/issue';
 import Issue from '../entity/Issue';
 import IssueComment from '../entity/IssueComment';
 import Media from '../entity/Media';
-import { IssueResultsResponse } from '../interfaces/api/issueInterfaces';
+import type { IssueResultsResponse } from '../interfaces/api/issueInterfaces';
 import { Permission } from '../lib/permissions';
 import logger from '../logger';
 import { isAuthenticated } from '../middleware/auth';

server/routes/media.ts

@@ -1,10 +1,11 @@
 import { Router } from 'express';
-import { FindOneOptions, FindOperator, getRepository, In } from 'typeorm';
+import type { FindOneOptions, FindOperator } from 'typeorm';
+import { getRepository, In } from 'typeorm';
 import TautulliAPI from '../api/tautulli';
 import { MediaStatus, MediaType } from '../constants/media';
 import Media from '../entity/Media';
 import { User } from '../entity/User';
-import {
+import type {
   MediaResultsResponse,
   MediaWatchDataResponse,
 } from '../interfaces/api/mediaInterfaces';

server/routes/request.ts

@@ -6,7 +6,7 @@ import Media from '../entity/Media';
 import { MediaRequest } from '../entity/MediaRequest';
 import SeasonRequest from '../entity/SeasonRequest';
 import { User } from '../entity/User';
-import { RequestResultsResponse } from '../interfaces/api/requestInterfaces';
+import type { RequestResultsResponse } from '../interfaces/api/requestInterfaces';
 import { Permission } from '../lib/permissions';
 import logger from '../logger';
 import { isAuthenticated } from '../middleware/auth';

server/routes/search.ts

@@ -1,6 +1,6 @@
 import { Router } from 'express';
 import TheMovieDb from '../api/themoviedb';
-import { TmdbSearchMultiResponse } from '../api/themoviedb/interfaces';
+import type { TmdbSearchMultiResponse } from '../api/themoviedb/interfaces';
 import Media from '../entity/Media';
 import { findSearchProvider } from '../lib/search';
 import logger from '../logger';

server/routes/service.ts

@@ -2,7 +2,7 @@ import { Router } from 'express';
 import RadarrAPI from '../api/servarr/radarr';
 import SonarrAPI from '../api/servarr/sonarr';
 import TheMovieDb from '../api/themoviedb';
-import {
+import type {
   ServiceCommonServer,
   ServiceCommonServerWithDetails,
 } from '../interfaces/api/serviceInterfaces';

server/routes/settings/index.ts

@@ -13,17 +13,19 @@ import TautulliAPI from '../../api/tautulli';
 import Media from '../../entity/Media';
 import { MediaRequest } from '../../entity/MediaRequest';
 import { User } from '../../entity/User';
-import { PlexConnection } from '../../interfaces/api/plexInterfaces';
-import {
+import type { PlexConnection } from '../../interfaces/api/plexInterfaces';
+import type {
   LogMessage,
   LogsResultsResponse,
   SettingsAboutResponse,
 } from '../../interfaces/api/settingsInterfaces';
 import { scheduledJobs } from '../../job/schedule';
-import cacheManager, { AvailableCacheIds } from '../../lib/cache';
+import type { AvailableCacheIds } from '../../lib/cache';
+import cacheManager from '../../lib/cache';
 import { Permission } from '../../lib/permissions';
 import { plexFullScanner } from '../../lib/scanners/plex';
-import { getSettings, MainSettings } from '../../lib/settings';
+import type { MainSettings } from '../../lib/settings';
+import { getSettings } from '../../lib/settings';
 import logger from '../../logger';
 import { isAuthenticated } from '../../middleware/auth';
 import { appDataPath } from '../../utils/appDataVolume';

server/routes/settings/notifications.ts

@@ -1,7 +1,7 @@
 import { Router } from 'express';
-import { User } from '../../entity/User';
+import type { User } from '../../entity/User';
 import { Notification } from '../../lib/notifications';
-import { NotificationAgent } from '../../lib/notifications/agents/agent';
+import type { NotificationAgent } from '../../lib/notifications/agents/agent';
 import DiscordAgent from '../../lib/notifications/agents/discord';
 import EmailAgent from '../../lib/notifications/agents/email';
 import GotifyAgent from '../../lib/notifications/agents/gotify';

server/routes/settings/radarr.ts

@@ -1,6 +1,7 @@
 import { Router } from 'express';
 import RadarrAPI from '../../api/servarr/radarr';
-import { getSettings, RadarrSettings } from '../../lib/settings';
+import type { RadarrSettings } from '../../lib/settings';
+import { getSettings } from '../../lib/settings';
 import logger from '../../logger';
 
 const radarrRoutes = Router();

server/routes/settings/sonarr.ts

@@ -1,6 +1,7 @@
 import { Router } from 'express';
 import SonarrAPI from '../../api/servarr/sonarr';
-import { getSettings, SonarrSettings } from '../../lib/settings';
+import type { SonarrSettings } from '../../lib/settings';
+import { getSettings } from '../../lib/settings';
 import logger from '../../logger';
 
 const sonarrRoutes = Router();

server/routes/user/index.ts

@@ -10,7 +10,7 @@ import Media from '../../entity/Media';
 import { MediaRequest } from '../../entity/MediaRequest';
 import { User } from '../../entity/User';
 import { UserPushSubscription } from '../../entity/UserPushSubscription';
-import {
+import type {
   QuotaResponse,
   UserRequestsResponse,
   UserResultsResponse,

server/routes/user/usersettings.ts

@@ -3,7 +3,7 @@ import { getRepository } from 'typeorm';
 import { canMakePermissionsChange } from '.';
 import { User } from '../../entity/User';
 import { UserSettings } from '../../entity/UserSettings';
-import {
+import type {
   UserSettingsGeneralResponse,
   UserSettingsNotificationsResponse,
 } from '../../interfaces/api/userSettingsInterfaces';